Re: [PATCH] prevent ia64 from invoking irq handlers on offline CPUs

[Paul E. McKenney]

On Sun, Aug 31, 2008 at 09:08:34PM +0200, Vegard Nossum wrote:
> On Sun, Aug 31, 2008 at 8:06 PM, Paul E. McKenney
> <paulmck@xxxxxxxxxxxxxxxxxx> wrote:
> > On Sun, Aug 31, 2008 at 07:53:32PM +0200, Vegard Nossum wrote:
> >> On Sun, Aug 31, 2008 at 7:51 PM, Paul E. McKenney
> >> <paulmck@xxxxxxxxxxxxxxxxxx> wrote:
> >> >> > @@ -751,6 +749,7 @@ int __cpu_disable(void)
> >> >> >        remove_siblinginfo(cpu);
> >> >> >        cpu_clear(cpu, cpu_online_map);
> >>
> >> Here ^^^
> >>
> >> >> >        fixup_irqs();
> >> >> > +       cpu_clear(cpu, cpu_online_map);
> >> >> >        local_flush_tlb_all();
> >> >> >        cpu_clear(cpu, cpu_callin_map);
> >> >> >        return 0;
> >> >>
> >> >> Hm. Maybe my eyes are going bad. But isn't that now clearing the cpu
> >> >> both before and after calling fixup_irqs()?
> >> >
> >> > I don't believe so...  I removed the earlier one and added the later
> >> > one.  Or is there another one hidden somewhere that I missed?
> >>
> >> See marker above. It's not removed, is it?
> >
> > Right you are!!!  There were two to begin with, and I moved the first
> > one only.  The attached updated patch removes the extra one.
> 
> Good, I am not blind yet! (Though I did have to look more than once.)
> 
> On the other hand... Paul; human after all!

Very much so, I am afraid!  ;-)

							Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/