Re: [PATCH 1/2] ne.c fix, res->name

[David Fries]

On Sun, Aug 31, 2008 at 12:03:57AM +0900, Atsushi Nemoto wrote:
> On Fri, 29 Aug 2008 21:44:25 -0500, David Fries <david@xxxxxxxxx> wrote:
> > +	if (!strcmp(res->name, BAD_STR))
> > +		dev->mem_end = BAD;
> 
> The res->name might be NULL.  You should check it first.
> 
> 	if (res->name && !strcmp(res->name, BAD_STR))
> 		dev->mem_end = BAD;

The name gets a valid string by that point in time.

drivers/base/platform.c:257
int platform_device_add(struct platform_device *pdev)

        for (i = 0; i < pdev->num_resources; i++) {
                struct resource *p, *r = &pdev->resource[i];

                if (r->name == NULL)
                        r->name = pdev->dev.bus_id;

-- 
David Fries <david@xxxxxxxxx>
http://fries.net/~david/ (PGP encryption key available)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/