Re: [PATCH] mm: hugetlb.c make functions static, use NULL ratherthan 0

From: Andrew Morton
Date: Fri Aug 29 2008 - 04:49:03 EST


On Fri, 29 Aug 2008 09:29:50 +0100 Andy Whitcroft <apw@xxxxxxxxxxxx> wrote:

> On Mon, Aug 25, 2008 at 10:27:39AM +0100, Hugh Dickins wrote:
> > On Fri, 22 Aug 2008, Harvey Harrison wrote:
> >
> > > mm/hugetlb.c:265:17: warning: symbol 'resv_map_alloc' was not declared. Should it be static?
> > > mm/hugetlb.c:277:6: warning: symbol 'resv_map_release' was not declared. Should it be static?
> > > mm/hugetlb.c:292:9: warning: Using plain integer as NULL pointer
> > > mm/hugetlb.c:1750:5: warning: symbol 'unmap_ref_private' was not declared. Should it be static?
>
> Harvey are you using some additional compiler flags to get this, I am
> pretty sure I checked for warnings during compilation before this lot
> was merged. Hmmm.

sparse. `make C=1'
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/