Re: [Patch] Fix another bug in hfsplus when reading a corruptedimage

From: Roman Zippel
Date: Thu Aug 28 2008 - 22:21:37 EST


Hi,

On Tue, 26 Aug 2008, Eric Sesterhenn wrote:

> Problem is that there is no ext_tree, causing the NULL-pointer
> dereference in hfsplus_init(). This fixes the issue by checking the ext_tree in
> hfsplus_get_block() and aborting early enoug.

The problem is worse, a corrupted extent for the extent file itself may
try to get an impossible extent, causing a deadlock if I see it correctly.
A better fix would be to check the inode number after the first_blocks
checks and fail if it's the extent file, as according to the spec the
extent file should have no extent for itself.

bye, Roman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/