Re: [PATCH 5/7] FUSE: implement ioctl support

[Tejun Heo]

Miklos Szeredi wrote:
>> Hmmm... I was trying to stay within similar operation mechanics as other
>> ops.  Directly accessing the caller's memory has performance benefits
>> but that benefit can also be used by reads and writes.  So, if we're
>> gonna do direct memory access, maybe doing it in more generic way is a
>> better idea?
> 
> On the contrary: playing VM games is going to be slow.  I think this
> approach is best suited for generic ioctl support because it
> simplifies the kernel part.  I'd hate to add all that complexity to
> the kernel if not absolutely necessary.

Well, it's only 240 lines with good amount of comments and iovec copying
function.  The ioctl itself isn't too complex.  I'm a bit skeptical
about direct access.  It can easily introduce security vulnerabilities
as there really is no way to hold a pid.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/