Re: [PATCH 2/2] uevent: handle duplicate uevent_var keys properly

From: Greg KH
Date: Thu Aug 28 2008 - 13:41:21 EST


On Thu, Aug 28, 2008 at 07:00:39PM +0200, Tejun Heo wrote:
> Greg KH wrote:
> > On Thu, Aug 28, 2008 at 06:31:02PM +0200, Tejun Heo wrote:
> >> add_uevent_var() appends the specified variable whether the new entry
> >> has duplicate key or not. This patch makes add_uevent_var() to
> >> override the existing entry if an entry with the same key is added
> >> later. This will be used by CUSE (character device in userland) to
> >> fake hotplug events.
> >
> > Hm, do you have any pointers to CUSE, that sounds interesting.
>
> I'm in the process of sending patches. I'll cc you on the actual postings.

Thanks, I'd appreciate that.

> > And how would this change interact with fake hotplug events?
>
> CUSE creates actual devices but those devices are all cuse class
> devices. To play nicely with sysfs/hal, the ADD/REMOVE uevents should
> have about the same variables as the actual device including the
> SUBSYSTEM, so that's where the overriding comes in. CUSE client tells
> CUSE that it needs to set such such envs for uevents and CUSE overrides
> uevents before sending it out so that sysfs/hal can be fooled.

Heh, nice, sounds interesting. I'll queue this patch up.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/