Re: [PATCH 3/5] checkpatch: complex macros need to ignore comments

[Andy Whitcroft]

On Sat, Jul 05, 2008 at 08:44:35PM +0200, Jan Engelhardt wrote:
> 
> On Wednesday 2008-07-02 13:31, Andy Whitcroft wrote:
> 
> >Ensure we ignore comments in complex macro detection else we incorrectly
> >report this:
> >
> >	#define PFM_GROUP_PERM_ANY     -1      /* any user/group */
> 
> Does it also catch this ugly piece from dcache.c?
> 
> 
> #define DCACHE_NFSFS_RENAMED  0x0002    /* this dentry has been "silly
>                                          * renamed" and has to be
>                                          * deleted on the last dput()
>                                          */

Yeah it should indeed.  A quick check with the current version seems to
confirm that.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/