Re: [PATCH] e1000: fix stack size

From: Jochen Voß
Date: Thu Aug 28 2008 - 06:17:34 EST


Hi,

2008/8/27 Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx>:
> From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
>
> Here's the patch. It shrinks the stack from 1152 bytes to 192 bytes (the
> first version, that only did the e1000_option part, got it down to 600
> bytes). About half comes from not using multiple "e1000_option"
> structures, the other half comes from turning the "e1000_opt_list[]"
> arrays into "static const" instead, so that gcc doesn't copy them onto the
> stack.
>
> Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Reveiewed-by: Auke Kok <auke-jan.h.kok@xxxxxxxxx>
^^^^^^^^^^^^^^
typo here

> Tested-by: Emil Tantilov <emil.s.tantilov@xxxxxxxxx>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx>

I hope this helps,
Jochen
--
http://seehuhn.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/