Re: [PATCH] ftrace: remove direct reference to mcount in trace code

From: Ingo Molnar
Date: Thu Aug 28 2008 - 03:50:58 EST



* Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> The mcount record method of ftrace scans objdump for references to
> mcount. Using mcount as the reference to test if the calls to mcount
> being replaced are indeed calls to mcount, this use of mcount was also
> caught as a location to change. Using a variable that points to the
> mcount address moves this reference into the data section that is not
> scanned, and we do not use a false location to try and modify.
>
> The warn on code was what was used to detect this bug.
>
> Signed-off-by: Steven Rostedt <srostedt@xxxxxxxxxx>

applied to tip/tracing/ftrace - thanks Steve!

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/