Re: [PATCH -V3 01/11] percpu_counters: make fbc->count read atomicon 32 bit architecture

[Andrew Morton]

On Thu, 28 Aug 2008 09:18:16 +0530 "Aneesh Kumar K.V" <aneesh.kumar@xxxxxxxxxxxxxxxxxx> wrote:

> > This is now too large to be inlined.
> > 
> 
> 
> How do we actually figure that out ? I have been making that mistakes
> quiet often.

Well.  Experience and guesswork, mainly.

But a useful metric is to look and the /bin/size output before and
after the inlining.  In this case fs/ext3/ialloc.o's text shrunk 40-odd
bytes, which we think is a net benefit due to reduced CPU cache
pressure.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/