Re: [PATCH] exit signals: use of uninitialized field notify_count

[Steve VanDeBogart]

On Wed, 27 Aug 2008, Ingo Molnar wrote:

> * Steve VanDeBogart <vandebo-lkml@xxxxxxxxxxx> wrote:
>
> > task->signal->notify_count is only initialized if
> > task->signal->group_exit_task is not NULL.  Reorder a conditional so
> > that uninitialised memory is not used.  Found by Valgrind.
> >
> > Signed-off-by: Steve VanDeBogart <vandebo-lkml@xxxxxxxxxxx>
>
> Applied the commit below to tip/core/urgent, thanks. Roland/Oleg, do you
> concur with the fix?
>
> nice find btw. - are you running Valgrind on UML?

Thanks.  Yes, I am running Valgrind on UML.  I revisited the previous 
patches that allowed it and tried to remove any unnecessary changes.
The patches and a recipe on how to make it work can be found on the
UML wiki: http://uml.jfdi.org/uml/Wiki.jsp?page=ValgrindingUML

I'll stir up trouble by posting the kernel patches on lkml after a
little more cleanup.

--
Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/