Re: pull request: wireless-2.6 2008-08-26

[Tomas Winkler]

On Thu, Aug 28, 2008 at 2:31 AM, Luis R. Rodriguez
<lrodriguez@xxxxxxxxxxx> wrote:
> On Wed, Aug 27, 2008 at 04:11:15PM -0700, Tomas Winkler wrote:
>> if (beacon_timestamp > rx_timestamp)
>>     merge
>>
>> The patch from Assaf just disable reporting RX timestamp to mac and
>> thus disabling merging which gives incorrect spec behavior but smooth
>> traffic.
>
> We *should follow the spec*.

I prefer to be able transfer files over blindly following spec. This
doesn't really break interoperability in practice.

>> Actually we've checked few cards including broadcom and various
>> windows NICs
>
> What are windows NICs?
>
>> and non of them implements this correctly so this WA is
>> probably the solution.
>
> Disagreed! If there is hardware which is not capable of handling this
> we should simply have a HW flag which specifies this to handle this as a
> work around (WA). Just because some cards are not capable it doesn't
> mean it should impose that on the rest.

This is w/a in the specific driver not in the mac so this is de facto
what you have suggested. This patch is marked as W/A and should have
probably
some cleaner solution in 2.6.28

>> Other solution would be to mark leader with highest TSF and not
>> reconnecting to the same station again and again.
>>
>> Last solution would be to remove this merging all together but then
>> I'm not sure if Bruno added this code just implement the spec or
>> really tested it with any hardware. I'm not sure if any vendor
>> implements PS in IBSS so this merging is probably not important
>> anyway.
>
> Absolutely not! IBSS merge is per spec, otherwise you don't really have
> a real IBSS.

I'm all for following spec and we've tried really hard to make it work.
Anyhow I'm not sure what you call real IBSS. nobody has checked it for
1.5 year this patch  is in and now is suddenly so important...
b43 was effected and probably also something that John worked with (as
he issued his anti-chatty patch)
I would like to see if there is any  HW under mac80211 that actually
work with this.

Tomas


>  Luis
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/