Re: [PATCH 1/2] utrace core

From: Alexey Dobriyan
Date: Wed Aug 27 2008 - 16:02:52 EST


1. UTRACE_ATTACH_MATCH_DATA is not used.

2. s/utrace_attached_engine/utrace_engine/g

Engine which is not attached is either just allocated or scheduled
for freeing

3. get_utrace_lock() is funny.

From name one should get valid struct utrace or -E depending only on
task, why engine matters is a mystery.

4. subsys_initcall

Just use module_init() or comment why it's needed.

5. Dummy in examiner -- not used (of course!)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/