Re: USB Serial device disconnect causes IRQ disable after usingehci controller halted

From: Greg KH
Date: Wed Aug 27 2008 - 14:14:10 EST


On Tue, Aug 26, 2008 at 11:35:04PM -0700, David Brownell wrote:
> On Tuesday 26 August 2008, amruth wrote:
> > This patch below does not fix the issue it just stops IRQ being
> > disabled but still ehci hcd crashes.
>
> That patch was only intended to address the issue of bogus error
> handling.
>
>
> > Please let me know what could be causing the issue.
>
> If it's like the other case, I'd hope this patch would solve it.
>
> Note that you also seem to be having hardware or firmware issues
> with the peripheral you're connecting ... this won't change that
> stuff at all.
>
> - Dave
>
> ================ SNIP!
> From: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
>
> As noted by Stefan Neis <Stefan.Neis@xxxxxxxxx>, we had a recent
> regression with EHCI periodic transfers, in some (seemingly not
> all that common) cases.
>
> The root cause was that the schedule activation was only loosely
> coupled to the addition or removal of transfers, so two different
> execution contexts could both think they had to deactivate (or
> conversely activate) the schedule. So this fix tightens that
> coupling, managing it more like a refcount.
>
> Signed-off-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>

Do you want me to also apply this one? If so, for .27 or .28?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/