Re: [PATCH 10/59] CRED: Wrap task credential accesses in the ISDN drivers

[Karsten Keil]

On Wed, Aug 27, 2008 at 02:46:33PM +0100, David Howells wrote:
> Wrap access to task credentials so that they can be separated more easily from
> the task_struct during the introduction of COW creds.
> 
> Change most current->(|e|s|fs)[ug]id to current_(|e|s|fs)[ug]id().
> 
> Change some task->e?[ug]id to task_e?[ug]id().  In some places it makes more
> sense to use RCU directly rather than a convenient wrapper; these will be
> addressed by later patches.
> 
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
> Reviewed-by: James Morris <jmorris@xxxxxxxxx>
> Acked-by: Serge Hallyn <serue@xxxxxxxxxx>
> Cc: Karsten Keil <kkeil@xxxxxxx>
> Cc: isdn4linux@xxxxxxxxxxxxxxxxxxxxxx
> ---
> 
>  drivers/isdn/capi/capifs.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> 
> diff --git a/drivers/isdn/capi/capifs.c b/drivers/isdn/capi/capifs.c
> index 550e80f..0aa66ec 100644
> --- a/drivers/isdn/capi/capifs.c
> +++ b/drivers/isdn/capi/capifs.c
> @@ -156,8 +156,8 @@ void capifs_new_ncci(unsigned int number, dev_t device)
>  	if (!inode)
>  		return;
>  	inode->i_ino = number+2;
> -	inode->i_uid = config.setuid ? config.uid : current->fsuid;
> -	inode->i_gid = config.setgid ? config.gid : current->fsgid;
> +	inode->i_uid = config.setuid ? config.uid : current_fsuid();
> +	inode->i_gid = config.setgid ? config.gid : current_fsgid();
>  	inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME;
>  	init_special_inode(inode, S_IFCHR|config.mode, device);
>  	//inode->i_op = &capifs_file_inode_operations;


Acked

-- 
Karsten Keil
SuSE Labs
ISDN and VOIP development
SUSE LINUX Products GmbH, Maxfeldstr.5 90409 Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/