Re: [ARM] Regression ? at91rm9200 machine-type

[Claudio Scordino]

Marc Pignat ha scritto:
> Hi!
>
> On Tuesday 26 August 2008, you wrote:
> > Hi,
> >
> >     I have a custom board equivalent to AT91RM9200DK.
> If it is really equivalent, you can use the same MACH_TYPE, else you should
> register another.

I used the same MACH_TYPE.

> > After commit
> >
> > 87fee013a23ad02821699aef5b76891b42959182
> >
> > [ARM] 4647/1: at91rm9200: Remove redundant machine-type verification
> > and manipulation
> >
> > I cannot boot my board anymore.
> >
> > Some more details:
> >   - I tried booting from both U-Boot 1.1.6 and U-Boot 1.3.4
> >   - I compiled U-Boot using "at91rm9200dk_config"
> >   - On U-Boot bootargs=console=ttyS0,115200 mem=32M
> > mtdparts=AT45DB642.spi0:-(filesystem) rootfstype=jffs2 root=/dev/mtdblock0
> >   - The .config of the kernel is in attachment
> >
> > I don't know if this is an actual regression or not (I'm not much
> > skilled in machine-types/boot process).
>
> The "default machine" selection is a *hack* for machines with a bootloader too
> old, buggy or closed source.
>
> The right fix is to change the MACH_TYPE that you've compiled in u-boot.
>
> > However, it seems that the commit above, besides removing redundant 
> > machine type verification, removed the default machine type for 
> > unknown boards as well.
>
> This is a cleanup patch, if the hack is not removed, bootloaders will *never*
> be fixed...

I see. Thank you for the explanations. Linux developers made things in
the right way by removing redundant machine type verification.

The bug is in U-Boot which passes the wrong mach type when compiled
for the at91rm9200dk board.

Many thanks for your quick answer.

             Claudio

--
Ing. Claudio Scordino		
Software Engineer, PhD
Tel. +39-050-5492050
http://retis.sssup.it/~scordino/

Evidence Srl
Embedded Real-Time Solutions
http://www.evidence.eu.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/