Re: An idea .... with code

From: Andi Kleen
Date: Wed Aug 27 2008 - 03:45:32 EST


On Wed, Aug 27, 2008 at 12:24:07AM -0700, jassi brar wrote:
> Exceptions(special cases) make for entropy and hence complexity. Generalization keeps uniformity and hences Order and Ease.

I fail to see what your patch generalizes? AFAIK it just adds a new
more narrow (less features than the old one) interface to create loop devices.

> I am not for discarding features from the system, but for implementing them in a way that is lesser intrusive.

But you're adding more code which is more intrusive?

> > Can you please expand a bit why you think losetup is that complicated
> > and what the problem is with it?
> Sir, i don't object to losetup as such. It is a utility made(specifically?) for LOOP devices: which implements unnecessary gears and switches to operate.
> I object only to what could be done without using ioctls and not to features that losetup provides for devices other than Loop(are there any?)

Your goal is to replace all ioctls with sysfs files?

If it's that then I'm going on the book as saying that's a bad idea, especially
for this case. While ioctls have their problems they work quite well for many
things. I don't see any particular reason why ioctls should not be used
to configure loop devices.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/