Re: [PATCH 3/4] pid_ns: de_thread: kill the now unneeded->child_reaper change

From: Serge E. Hallyn
Date: Tue Aug 26 2008 - 22:32:00 EST


Quoting Oleg Nesterov (oleg@xxxxxxxxxx):
> de_thread() checks if the old leader was the ->child_reaper, this is not
> possible any longer. With the previous patch ->group_leader itself will
> change ->child_reaper on exit.

Neat.

> >From now find_new_reaper() is the only function (apart from initialization)
> which plays with ->child_reaper.
>
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>

Acked-by: Serge Hallyn <serue@xxxxxxxxxx>

>
> --- 2.6.27-rc4/fs/exec.c~3_EXEC 2008-07-30 13:12:47.000000000 +0400
> +++ 2.6.27-rc4/fs/exec.c 2008-08-24 19:20:05.000000000 +0400
> @@ -825,8 +825,6 @@ static int de_thread(struct task_struct
> schedule();
> }
>
> - if (unlikely(task_child_reaper(tsk) == leader))
> - task_active_pid_ns(tsk)->child_reaper = tsk;
> /*
> * The only record we have of the real-time age of a
> * process, regardless of execs it's done, is start_time.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/