Re: [PATCH 0/5] use lspci style for [%04x:%04x] vendor/device

From: Bjorn Helgaas
Date: Tue Aug 26 2008 - 12:55:37 EST


On Monday 25 August 2008 05:53:13 pm Alexey Dobriyan wrote:
> On Mon, Aug 25, 2008 at 03:05:25PM -0700, Arjan van de Ven wrote:
> > On Mon, 25 Aug 2008 16:01:38 -0600
> > Bjorn Helgaas <bjorn.helgaas@xxxxxx> wrote:
> >
> > > These patches change various debug messages to use "[%04x:%04x]" for
> > > PCI vendor/device IDs to follow the format used by lspci(8).
> >
> > I hope you're adding a new whicked special format specifier for this
> > ... taking a PCI dev struct as argument.
> >
> > That's be really nice to have;-)
>
> You should sign Treaty of the Non-Proliferation of Format Specifiers.
>
> Untill too late...

OK. I'll wait with any new format specifiers for now. Relative to
something like printing resources, where a new format specifier could
help get rid of a ton of ugly casts, this PCI vendor/device stuff
is pretty minor.

Bjorn

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/