Re: [rtc-linux] Re: [RFC] Driver for Real Time Clock chip ST M41T65

From: Steven A. Falco
Date: Tue Aug 26 2008 - 10:43:17 EST


Alessandro Zummo wrote:
> On Tue, 26 Aug 2008 15:00:03 +0100
> "Will Newton" <will.newton@xxxxxxxxx> wrote:
>
>
>>>> On Mon, Aug 25, 2008 at 6:27 PM, Steven A. Falco <sfalco@xxxxxxxxxx> wrote:
>>>>> I will be using a Real Time Clock chip, ST M41T65, on a new embedded system.
>>>>> The chip is quite similar to the M41T8x family, which already has driver
>>>>> rtc-m41t80.c.
>>>>>
>>>>> Would it be more acceptible to generalize rtc-m41t80.c (perhaps renaming it to
>>>>> rtc-m41txx.c) or would it be better to create a new rtc-m41t6x.c?
>>> Thanks for the feedback. Here is a respin which addresses your comments.
>>>
>>> I'd also like to know if I should submit a new driver or mod the existing
>>> one. If I mod the existing one, should it be renamed, should I update the
>>> Kconfig, existing defconfigs, etc?
>
> Given the small amount of changes, I would use the existing driver without
> renaming it.
>

Sounds good. Please let me know if there are other changes needed to make this
patch acceptable for inclusion into the mainline.

Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/