Re: [BUG] cpufreq: constant cpu_khz

From: Dave Jones
Date: Mon Aug 25 2008 - 13:54:52 EST


On Mon, Aug 25, 2008 at 02:39:26PM +0200, Ingo Molnar wrote:
>
> * Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
> > > I noticed that my sched_clock() was slow on a number of machine, so
> > > I started looking at cpufreq.
> >
> > The below seems to fix the problem for me, but I don't have enough
> > clue to know if its the correct fix, please advise.
>
> > - set_cyc2ns_scale(tsc_khz_ref, freq->cpu);
> > + set_cyc2ns_scale(tsc_khz, freq->cpu);
>
> hm, that too is due to the tsc.c unification - Alok Cc:-ed. Applied your
> fix to x86/urgent.

ACKed-by: Dave Jones <davej@xxxxxxxxxx>

Good catch Peter. I'm puzzled how that bug was latent on 64bit
for so long with no-one realising though.

Dave

--
http://www.codemonkey.org.uk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/