Re: [PATCH] Fix emergency_restart (sysrq-b) with kvm loaded on Intelhosts

From: Avi Kivity
Date: Mon Aug 25 2008 - 06:03:32 EST


Ingo Molnar wrote:



I'm a little worried about making emergency restart more complex.

Another thing that worries me is that emergency_restart() doesn't reset the box -- it sends INIT. We could do better by using the ACPI FADT reset register (hopefully that's connected to RESET).

reboot was always a bit fragile - i think we should only do that if we find a box where the FADT reset works better than the first-wave approaches we try.


It worked on my host. Since it will fall back to keyboard reset and triple fault, it seems fairly safe.

Which seems to be what we want? Maybe we should just try acpi_reboot() before the other stuff.

perhaps in a separate commit, for v2.6.28 at the earliest.

I'll send a patch. I don't think my earlier patch is worthwhile as all machines with VT are acpi capable.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/