UML Reboot Panic

From: Tom Spink
Date: Sun Aug 24 2008 - 16:58:18 EST


Hi,

When using UML with a UML block device, and issuing a reboot, I was
getting a kernel panic on the next kernel startup because UML was
unable to open the file mapped to the UBD. I think this is because
the file is not closed when the UBD is released, and the following
patch appears to resolve this issue. I'm not sure if it's the right
fix, as I may have missed something, but it works for me.

-- Tom

diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c
index b58fb89..946a171 100644
--- a/arch/um/drivers/ubd_kern.c
+++ b/arch/um/drivers/ubd_kern.c
@@ -802,6 +802,7 @@ static void ubd_device_release(struct device *dev)
struct ubd *ubd_dev = dev->driver_data;

blk_cleanup_queue(ubd_dev->queue);
+ os_close_file(ubd_dev->fd);
*ubd_dev = ((struct ubd) DEFAULT_UBD);
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/