Re: [PATCH](retry 3) invalidate caches before going into suspend

[Arjan van de Ven]

On Thu, 14 Aug 2008 08:45:04 -0500
Mark Langsdorf <mark.langsdorf@xxxxxxx> wrote:

> When a CPU core is shut down, all of its caches need to be flushed
> to prevent stale data from causing errors if the core is resumed.
> Current Linux suspend code performs an assignment after the flush,
> which can add dirty data back to the cache. ÂOn some AMD platforms,
> additional speculative reads have caused crashes on resume because
> of this dirty data.
> 
> Relocate the cache flush to be the very last thing done before 
> halting. ÂTie into an assembly line so the compile will not
> reorder it. ÂAdd some documentation explaining what is going
> on and why we're doing this.


looks good to me

Acked-by: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>


-- 
If you want to reach me at my work email, use arjan@xxxxxxxxxxxxxxx
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/