Possible false positive in checkpatch

From: Alan Stern
Date: Tue Aug 12 2008 - 10:25:29 EST


The following appears to be a false positive in checkpatch:

ERROR: space prohibited after that '*' (ctx:BxW)
#163: FILE: drivers/usb/core/usb.c:304:
+#define usb_device_pm_ops (* (struct pm_ops *) 0)
^

Certainly this is a rather uncommon code construction, but similar
ones might occur elsewhere. To my eyes,

(* (type *) ptr)

looks better than

(*(type *) ptr)

or

(*(type *)ptr)

or even

(*(type*)ptr)

but of course this is a matter of opinion. Is there any strong feeling
about this in the kernel community?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/