Re: [PATCH] PNP: make the resource type an unsigned long

From: Rene Herman
Date: Tue Aug 12 2008 - 00:15:01 EST


On 11-08-08 23:59, Bjorn Helgaas wrote:

On Friday 08 August 2008 12:39:45 am Rene Herman wrote:
Andrew earlier commented that pci_resourec_flags() returns an unsigned long. Had this hanging around a local branch. Useful?

I see hpa's point that it makes no functional difference, but I do
think it's worthwhile to make the types match. I don't want to
debug the problem that happens when somebody adds an IORESOURCE_*
flag in the upper bits.

You probably want to send this (and the next one, which is really
a pci_resource_flags() usage despite being in drivers/pnp/quirks.c)
to Andi Kleen.

Acked-by: Bjorn Helgaas <bjorn.helgaas@xxxxxx>

Okay, thanks. I see that Andrew picked these up with Andi in CC so I'll assume things will find their way from there.

Rene.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/