Re: [PATCH] cpuset: Rework sched domains and CPU hotplug handling(take 4)

From: Max Krasnyansky
Date: Mon Aug 11 2008 - 23:27:57 EST


Rakib Mullick wrote:
> One more thing Max, while you are allocating memory for "dattr" I
> think it needs to check that it is successful or not . I've shown it
> on one of my previous patch on 7th Aug.

I think you missed this part of the patch

> + /*
> + * The rest of the code, including the scheduler, can deal with
> + * dattr==NULL case. No need to abort if alloc fails.
> + */
> dattr = kmalloc(ndoms * sizeof(struct sched_domain_attr), GFP_KERNEL);

I replied to your patch saying that we do not need to check it. And Paul
suggested to add a comment to explain why.

Max


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/