Re: [PATCH] Backlight driver for Tabletkiosk Sahara TouchIT-213Tablet PC

[Andrew Morton]

On Mon, 28 Jul 2008 22:03:00 +0200
Claudio Nieder <private@xxxxxxxxxx> wrote:

>
> ...
>
> +void kb3886_bl_set_intensity(int intensity)
> +{
> +	mutex_lock(&bl_mutex);
> +	intensity = intensity&0xff;
> +	outb(KB3886_ADC_DAC_PWM, KB3886_PARENT);
> +	mdelay(10);
> +	outb(KB3886_PWM0_WRITE, KB3886_IO);
> +	mdelay(10);
> +	outb(intensity, KB3886_IO);
> +	mutex_unlock(&bl_mutex);
> +}

I believe the mdelay()s could be converted to the preferable msleep()?

> ...
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/