Re: [RFC PATCH] cleanup Serial ATA and Parallel ATA Kconfig

[Oliver Pinter]

On 8/9/08, Krzysztof Halasa <khc@xxxxxxxxx> wrote:
> Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> writes:
>
>> Alas it does not or we would have done so. A lot of the chips have things
>> like 'two SATA one PATA' and some of them have SATA and PATA variants of
>> the same chip. Then we have generic drivers like ata_generic which really
>> don't care if its SATA or PATA ..
>
> Then I would enable them if SATA _or_ PATA is selected. Something like
> the following. Then the driver list (one common list) could be sorted,
> ATA_SFF moved to the end etc.
>
> It complicates the Kconfig, I don't know if users' experience is worth
> it in the end.
>
> I'm not sure about IXP4XX_CF (compact flash) case, it's essentially
> PATA but the physical interface is a bit different and it may be
> confusing(?). Also not sure about Pacific Digital ADMA, is it
> PATA-only or both?
>
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -3,7 +3,7 @@
>  #
>
>  menuconfig ATA
> -	tristate "Serial ATA (prod) and Parallel ATA (experimental) drivers"
> +	tristate "Serial ATA and Parallel ATA drivers"
>  	depends on HAS_IOMEM
>  	depends on BLOCK
>  	depends on !(M32R || M68K) || BROKEN
> @@ -23,6 +23,21 @@ menuconfig ATA
>
>  if ATA
>
> +config ATA_PATA
> +	bool "Parallel ATA (PATA) support"
> +	depends on ATA
> +	help
> +	  Say Y here if you want support for Parallel ATA devices, previously
> +	  known as IDE. This also includes Compact Flash slots.
> +
> +config ATA_SATA
> +	bool "Serial ATA (SATA) support"
> +	depends on ATA
> +	help
> +	  Say Y here if you want support for Parallel ATA devices.

s/Parallel/Serial/

[...]

-- 
Thanks,
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/