Re: [PATCH -v2 6/8] kexec jump: fix for lockdep

From: Peter Zijlstra
Date: Fri Aug 08 2008 - 06:14:47 EST


On Fri, 2008-08-08 at 14:52 +0800, Huang Ying wrote:
> Replace local_irq_disable() with raw_local_irq_disable() to prevent
> lockdep complain.


Uhhm, please provide more information - just using raw_* to silence
lockdep is generally the wrong thing to do.

> Signed-off-by: Huang Ying <ying.huang@xxxxxxxxx>
>
> ---
> arch/x86/kernel/machine_kexec_32.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/arch/x86/kernel/machine_kexec_32.c
> +++ b/arch/x86/kernel/machine_kexec_32.c
> @@ -123,7 +123,7 @@ void machine_kexec(struct kimage *image)
> tracer_disable();
>
> /* Interrupts aren't acceptable while we reboot */
> - local_irq_disable();
> + raw_local_irq_disable();
>
> if (image->preserve_context) {
> #ifdef CONFIG_X86_IO_APIC
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/