Re: [PATCH]Fix broken VMI in 2.6.27-rc..

From: Linus Torvalds
Date: Thu Aug 07 2008 - 18:39:51 EST




On Thu, 7 Aug 2008, H. Peter Anvin wrote:
>
> The only way I can see around that, though, is to move the 1:1 mapping base up
> by 2/4 MB (for PAE/no PAE, respectively) and put the fixmap area there. Kind
> of sucks, but would be doable.

So if the address isn't fixed, you'll end up with an indirect pointer, and
it would likely be much better to just use a fixed direct pointer that is
not at the top.

And anything that is within the top 31 bits of the address space should
generate the same good code, since the fixed offset is always going to be
a 32-bit thing anyway. So moving the FIXMAP area down by 4MB sounds like a
fine thing to do with no real downside, if it then means that we don't
need to move the FIXMAP area at all.

Hmm? Am I missing something?

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/