[PATCH] isight_firmware : Fix a leak and double kfree()

[Parag Warudkar]

Signed-off-by: Parag Warudkar <parag.warudkar@xxxxxxxxx>

--- linux-2.6/drivers/usb/misc/isight_firmware.c	2008-07-29
23:26:24.000000000 -0400
+++ linux-2.6-wk/drivers/usb/misc/isight_firmware.c	2008-08-07
13:23:01.000000000 -0400
@@ -48,7 +48,8 @@

 	if (request_firmware(&firmware, "isight.fw", &dev->dev) != 0) {
 		printk(KERN_ERR "Unable to load isight firmware\n");
-		return -ENODEV;
+		ret = -ENODEV;
+		goto out;
 	}

 	ptr = firmware->data;
@@ -91,7 +92,6 @@
 			     buf, llen, 300) != llen) {
 				printk(KERN_ERR
 				       "Failed to load isight firmware\n");
-				kfree(buf);
 				ret = -ENODEV;
 				goto out;
 			}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/