Re: [PATCH 1/2] pci: add misrouted interrupt error handling

From: Greg KH
Date: Thu Aug 07 2008 - 13:22:58 EST


On Thu, Aug 07, 2008 at 09:03:22AM -0700, Jesse Barnes wrote:
> On Tuesday, August 5, 2008 2:54 pm James Bottomley wrote:
> > > or somesuch. That seems just as simple for driver writers as your
> > > initial patch, and the function is named in accordance with what it
> > > actually does, rather than what it's used for...
> >
> > It could, but if the bridge is the culprit (as it usually is for MSI
> > problems), this print won't help identify it.
> >
> > Therefore, rather than give driver writers a recipe for "print this and
> > this and go to the bridge and print this", I'd rather have a single PCI
> > callback that prints all the (hopefully) relevant information that will
> > allow either fixing or blacklisting.
>
> So in addition to the IRQ type check we need to dump some device topology
> information... yeah that makes sense. I wonder if the driver core should
> provide something like this. Greg?

What kind of topology do you need that is not already provided?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/