Re: [PATCH] radeon_cp: use request_firmware

[Jaswinder Singh]

Hello Gene,

On Thu, 2008-08-07 at 06:24 -0400, Gene Heskett wrote:

> When applied to 2.6.27-rc2, firmware/Makefile was rejected, so I manually added 
> the blob list to that Makefile in what looked to be the correct place.  And added a
> "make firmware_install" to my kernel builder script.
> 
> Unforch:
>   MK_FW   firmware/R100_cp.bin.ihex.gen.S
> make[1]: *** No rule to make target `firmware/R100_cp.bin.ihex', needed by `firmware/R100_cp.bin.ihex.gen.o'.  Stop.
> make[1]: *** Waiting for unfinished jobs....
> make: *** [firmware] Error 2
> 

It seems your firmware/Makefile is not good.

it should look like this :-

fw-shipped-$(CONFIG_DRM_RADEON) += radeon/R100_cp.bin radeon/R200_cp.bin \
                                   radeon/R300_cp.bin radeon/R420_cp.bin \
                                   radeon/RS600_cp.bin radeon/RS690_cp.bin \
                                   radeon/R520_cp.bin


I think you forget to write radeon before R100_cp.bin

And you can collect my updated patch from :
http://git.infradead.org/users/jaswinder/firm-jsr-2.6.git

Thank you,

Jaswinder Singh.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/