Re: [PATCH AVAIL.]ivtv:Crash 2.6.26 with KUROTOSIKOU CX23416-STVLP

[Jean Delvare]

Hi Hans,

On Sun, 3 Aug 2008 23:12:25 +0200, Hans Verkuil wrote:
> Hi Ohta,
> 
> Well, I picked up my card this weekend and tested it. It turns out to be 
> an i2c-core.c bug: chips with i2c addresses in the 0x5x range are 
> probed differently than other chips and the probe command contains an 
> error. The upd64083 has an address in that range and so was hit by this 
> bug. The attached patch for linux/drivers/i2c/i2c-core.c will fix it.
> 
> As you can see, this mail also goes to Jean Delvare so that he can move 
> this upstream (should also go to the 2.6.26-stable series, Jean!).
> 
> For the ivtv driver this bug will only hit cards where ivtv has to probe 
> for an upd64083.
> 
> SoB for this patch:
> 
> Signed-off-by: Hans Verkuil <hverkuil@xxxxxxxxx>
> 
> I've verified that this is only an issue with kernels 2.6.26 and up. 
> Older kernels are not affected unless the ivtv driver from the v4l-dvb 
> repository is used. To be more precise: this bug has been in i2c-core.c 
> since 2.6.22, but the ivtv driver in 2.6.26 was the first driver that 
> used i2c_new_probed_device() with an i2c address in a range that caused 
> the broken probe to be used.

Good catch, thanks for the patch. I'll push it to Linus by the end of
the week.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/