Re: [PATCH 00/33] dyn_array and nr_irqs support v4

From: Alan Cox
Date: Thu Aug 07 2008 - 08:25:21 EST


> #ifndef CONFIG_HAVE_SPARSE_IRQ
> #define valid_irq(irq) ((irq) > 0 && (irq) < nr_irqs)
> #else
> #define valid_irq(irq) ((irq) > 0)

For a sparse IRQ you might want to call an arch specific bit of C to do
the validating. Not sure that matters too much though as must user set
interrupts are ISA 8)

> anyway why 0 is invalid instead of -1U...?

So you can write the natural thing in C

if (!dev->irq)
poll_device();

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/