Re: [PATCH 00/33] dyn_array and nr_irqs support v4

From: Eric W. Biederman
Date: Wed Aug 06 2008 - 21:13:32 EST


Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> writes:

> A lot of these are range checks so could be replaced by a single
> valid_irq(irq) test.

Yes. My first impression was that with NR_IRQS dead valid_irq could
easily become. #define valid_irq(irq) ((irq) != 0) However thinking
just a little more since ultimately we will know which irqs have
something hooked up to them we might actually be able to say something
more interesting. So I guess actually having a valid irq function
makes sense. Instead of doing the idiomatic if (irq) logic inline.

Eric

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/