Re: [Ksummit-2008-discuss] Kernel Summit request for Discussion offuture of ATA (libata) and IDE

From: Tejun Heo
Date: Wed Aug 06 2008 - 09:05:22 EST


Sergei Shtylyov wrote:
> Hello.
>
> Tejun Heo wrote:
>>> +unsigned int ata_sff_data_xfer(struct ata_device *dev, unsigned char *buf,
>>> + unsigned int buflen, int rw)
>>> +{
>>> + struct ata_port *ap = dev->link->ap;
>>> + void __iomem *data_addr = ap->ioaddr.data_addr;
>>> + unsigned int words = buflen >> 2;
>>>
>> dwords maybe?
>>
>
> Isn't word 32-bit in the 32-bit systems? We're not on 80[12]86
> (despite Intel/MS preference of calling 32-bit memory cells DWORDS)...

Well, as most of machines are 64-bit these days, discussing whether a
word means 16 or 32 bits is kind of moot. I usually just think byte,
word, dword, qword and and libata and pci assume that too -
ata_id_has_dword_io() and PCI configuration accessors. It's ultimately
a peripheral issue either way tho.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/