Re: serial/bfin_5xx.c build error

[Adrian Bunk]

On Tue, Aug 05, 2008 at 11:58:44AM +0800, Bryan Wu wrote:
> On Sun, Aug 3, 2008 at 2:16 AM, Adrian Bunk <bunk@xxxxxxxxxx> wrote:
> > Seems to be broken by Alan's changes:
> >
> 
> I'm trying to locate the Alan's change, do you know it, Adrian?
> 
> > <--  snip  -->
> >
> > ...
> >  CC      drivers/serial/bfin_5xx.o
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c: In function 'bfin_serial_set_ldisc':
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c:820: error: 'struct tty_ldisc' has no member named 'num'
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c: In function 'bfin_serial_console_write':
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c:1001: warning: comparison of distinct pointer types lacks a cast
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c:1003: warning: comparison of distinct pointer types lacks a cast
> > make[3]: *** [drivers/serial/bfin_5xx.o] Error 1
> >
> > <--  snip  -->
> 
> So is this bug in mainline upstream or linux-next latest tree?

It was a bug in the mainline upstream kernel.

Alan fixed it with comit b1cbefe5d5fc2d4a6109961d914027172ce8e152 
(blackfin: Fix compile failure in tty code) that went into
Linus' tree last night.

> Thanks
> -Bryan

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/