Re: [PATCH] [PM] Fixes missing PM entries in sysfs without CONFIG_PM_SLEEP

From: Rafael J. Wysocki
Date: Mon Aug 04 2008 - 11:21:43 EST


On Monday, 4 of August 2008, Alan Stern wrote:
> On Mon, 4 Aug 2008, Rafael J. Wysocki wrote:
>
> > > Rafael, any objections?
> >
> > Hm, well, one thing below.
>
> > device_pm_add() can now be void and the error variable in there is not
> > necessary any more.
>
> Do you think we will want to make device_pm_add() return an error at
> some point in the future?

Well, maybe, but not any time soon. :-)

> For example, earlier you had it fail if the parent device was asleep, instead
> of just printing a warning.

Yes, I remeber it, but there still are some drivers that would break if we
did that.

Anyway, I think it won't be hard to change device_pm_add() to return error
codes again if we decide to in future.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/