Re: [PATCH] net: Add missing extra2 parameter for ip_default_ttlsysctl

[David Miller]

From: Sven Wegener <sven.wegener@xxxxxxxxxxx>
Date: Sun, 3 Aug 2008 22:18:59 +0200 (CEST)

> Commit 76e6ebfb40a2455c18234dcb0f9df37533215461 acceses the extra2 parameter of
> the ip_default_ttl ctl_table, but it is never set to a meaningful value. When
> e84f84f276473dcc673f360e8ff3203148bdf0e2 is applied, we'll oops in
> rt_cache_invalidate(). Set extra2 to init_net, to avoid that.
> 
> Reported-by: Marcin Slusarz <marcin.slusarz@xxxxxxxxx>
> Signed-off-by: Sven Wegener <sven.wegener@xxxxxxxxxxx>
> Tested-by: Marcin Slusarz <marcin.slusarz@xxxxxxxxx>
> Acked-by: Denis V. Lunev <den@xxxxxxxxxx>

Applied, thanks a lot.

Please provide commit header line text when referencing SHA IDs,
as the SHA IDs can change when patches are applied to different
trees.  Here is the actual changelog message I used so you can
see what I mean:

    net: Add missing extra2 parameter for ip_default_ttl sysctl
    
    Commit 76e6ebfb40a2455c18234dcb0f9df37533215461 ("netns: add namespace
    parameter to rt_cache_flush") acceses the extra2 parameter of the
    ip_default_ttl ctl_table, but it is never set to a meaningful
    value. When e84f84f276473dcc673f360e8ff3203148bdf0e2 ("netns: place
    rt_genid into struct net") is applied, we'll oops in
    rt_cache_invalidate(). Set extra2 to init_net, to avoid that.
    
    Reported-by: Marcin Slusarz <marcin.slusarz@xxxxxxxxx>
    Signed-off-by: Sven Wegener <sven.wegener@xxxxxxxxxxx>
    Tested-by: Marcin Slusarz <marcin.slusarz@xxxxxxxxx>
    Acked-by: Denis V. Lunev <den@xxxxxxxxxx>
    Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/