Re: [PATCH 1/2] pata_legacy: export functionality to ide

[Borislav Petkov]

On Sun, Aug 03, 2008 at 12:59:07PM +0100, Alan Cox wrote:
> On Sun, 3 Aug 2008 09:37:56 +0200
> Borislav Petkov <petkovbb@xxxxxxxxxxxxxx> wrote:
> 
> > Ok, here's a definitely better solution:
> 
> Please don't stuff large important pieces of code in header files where
> they will be overlooked

What do you mean by "overlooked"? If you're looking for the function defintion,
any sensible code indexing tool will point you to the right place.

And linux/ata.h already contains several c one liners/helpers. What is the
difference between the two new functions and the ones already present there?
Although the solution i propose is not adhering to some header/c file
conventions, it is still the best one considering the other possibilities:

a) code duplication: dumb idea, bloated kernel for no reason

b) evil Kconfig SELECT pulling in core libata just so that ide might be calling
a function or two.

[.. ]


-- 
Regards/Gruss,
    Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/