Re: [PATCH 00/25] dyn_array and nr_irqs support v3

[Yinghai Lu]

On Sat, Aug 2, 2008 at 10:51 PM, Eric W. Biederman
<ebiederm@xxxxxxxxxxxx> wrote:
>
> It appears that quite a few of the places you have changed are testing
> to see if an irq is valid.  The idiomatic way to perform that test in
> the kernel is:
>
> if (irq)

is uninitialized irq to be -1 or 0?

>
> With no test to see if you are >= NR_IRQS.
>
> I expect that is the change we want in the drivers that are performing such a silly
> extra check.

is_irq_valid(irq_no) ?

wait to see your new patchset about dyn irq_cfg and irq_desc

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/