Re: [PATCH] drivers/mtd/mtdsuper.c: fix build error

[Adrian Bunk]

On Sun, Aug 03, 2008 at 03:40:12AM +0400, Alexander Beregalov wrote:
> 2008/8/3 Adrian Bunk <bunk@xxxxxxxxxx>:
> > On Sun, Aug 03, 2008 at 02:53:04AM +0400, Alexander Beregalov wrote:
> >> From: Alexander Beregalov <a.beregalov@xxxxxxxxx>
> >>
> >> drivers/mtd/mtdsuper.c: fix build error
> >>
> >> drivers/mtd/mtdsuper.c:184: error: implicit declaration of
> >>       function 'lookup_bdev'
> >> drivers/mtd/mtdsuper.c:197: error: implicit declaration of
> >>       function 'bdput'
> >
> >
> > It already gets fs.h indirectly through linux/mtd/super.h, so while
> > your patch might be correct it cannot fix a compile error.
> >
> > If that's with CONFIG_BLOCK=n then it's
> >  http://bugzilla.kernel.org/show_bug.cgi?id=11225
> >
> > Otherwise please send your .config .
> 
> I do not have this config, I collect log from builds with randconfig
> and try to fix problems.
>...

You must store the config of the failed builds somewhere, since 
otherwise (like in this case) you cannot verify whether a patch
actually fixes a problem.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/