Re: [RFC, 2.6.26.2-rc1] fs/partition/check.c: fix return value warning

From: Oliver Pinter
Date: Sat Aug 02 2008 - 16:09:43 EST


Willy, this good to know ...

and I think, this patch fixed a small leak:

+
+out2:
+ device_del(&p->dev);
+out1:
+ put_device(&p->dev);
+ free_part_stats(p);
+out0:
+ kfree(p);
+ return err;


On 8/2/08, Willy Tarreau <w@xxxxxx> wrote:
> On Sat, Aug 02, 2008 at 12:56:10PM -0700, Linus Torvalds wrote:
>> Please don't just send patches to the stable team because they "look
>> fine". They should be real bugs, with real consequences. And no, a
>> compiler warning is not a real consequence.
>
> BTW, before Oliver does the mistake, I'd suggest never forwarding
> network patches to stable either as Davem already maintains his
> own -stable queue ;-)
>
> Willy
>
>


--
Thanks,
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/