Re: [PATCH 2/6] Container Freezer: Make refrigerator always available

From: Rafael J. Wysocki
Date: Sat Aug 02 2008 - 10:32:22 EST

Next message: Rafael J. Wysocki: "Re: [PATCH 3/6] Container Freezer: Implement freezer cgroup subsystem"
Previous message: Alexey Dobriyan: "Re: [PATCH 2/2] cpuset: use seq_cpumask(), seq_nodemask()"
In reply to: Matt Helsley: "Re: [PATCH 2/6] Container Freezer: Make refrigerator alwaysavailable"
Next in thread: Matt Helsley: "Re: [PATCH 2/6] Container Freezer: Make refrigerator alwaysavailable"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Saturday, 2 of August 2008, Matt Helsley wrote:
>
> On Sat, 2008-08-02 at 00:53 +-0200, Rafael J. Wysocki wrote:
> > On Friday, 1 of August 2008, Matt Helsley wrote:
> > >
> > > On Fri, 2008-08-01 at 16:27 +-0200, Thomas Petazzoni wrote:
> > > > Hi,
> > > >
> > > > Le Thu, 31 Jul 2008 22:07:01 -0700,
> > > > Matt Helsley <matthltc@xxxxxxxxxx> a +AOk-crit :
> > > >
> > > > > --- a/kernel/Makefile
> > > > > +-+-+- b/kernel/Makefile
> > > > > @@ -5,7 +-5,7 @@
> > > > > obj-y = sched.o fork.o exec_domain.o panic.o printk.o +AFw
> > > > > cpu.o exit.o itimer.o time.o softirq.o resource.o +AFw
> > > > > sysctl.o capability.o ptrace.o timer.o user.o +AFw
> > > > > - signal.o sys.o kmod.o workqueue.o pid.o +AFw
> > > > > +- signal.o sys.o kmod.o workqueue.o pid.o freezer.o +AFw
> > > >
> > > > I have the impression that the code in kernel/power/process.c was
> > > > compiled only if CONFIG_PM_SLEEP was set. Now that the code has been
> > > > moved to kernel/freezer.c, it is unconditionnaly compiled in every
> > > > kernel. Is that correct ?
> > > >
> > > > If so, is it possible to put this new feature under some
> > > > CONFIG_SOMETHING option, for people who care about the kernel size ?
> > >
> > > How about making it depend on a combination of CONFIG variables?
> > > Here's an RFC PATCH. Completely untested.
> > >
> > > Signed-off-by: Matt Helsley <matthltc@xxxxxxxxxx>
> >
> > Can you please also make the contents of include/linux/freezer.h depend on
> > CONFIG_FREEZER instead of CONFIG_PM_SLEEP?
>
> Good point -- I'll add that to this patch and repost.
>
> > Also, I'm not really sure if kernel/power/Kconfig is the right place to define
> > CONFIG_FREEZER.
>
> There's no nice place to put it since we're dealing with CONFIG_
> variables in two different Kconfig files. I put it in
> kernel/power/Kconfig because I wasn't certain Kbuild would do the right
> thing if I referenced PM_SLEEP from init/Kconfig.
>
> > Perhaps we should even move freezer.c from kernel/power to kernel
>
> It's already there.

Yes, sorry.

> Perhaps you meant something else (kernel/power/process.c?)?

Well, I'll have to actually apply the patches and look at the modified code.

> > and define CONFIG_FREEZER in Kconfig in there. Andrew, what do you think?
>
> The Kconfig files in kernel/ are Kconfig.hz and Kconfig.preemt which
> don't seem appropriate. I suppose we could add another (perhaps
> Kconfig.cgroup).

Either that, or Kconfig.freezer maybe? After all, it will also be used for
PM_SLEEP, at least for some time.

> Thanks for the review!

You're welcome.

Thanks,
Rafael
7mNóůnĐ7mNóp4o0žgApŕŔŠMóĐ7mNó 5oĐ7mNóůnĐ7mNó`5o5oŃpŕŔŠMóĐ7mNó 5oĐ7mNóůnĐ7mNóP6op6oapŕŔŠMóĐ7mNó6oĐ7mNóůnĐ7mNó@7o`7ońpŕŔŠMóĐ7mNó7oĐ7mNóůnĐ7mNó08oP8opŕŔŠMóĐ7mNóp8oĐ7mNóůnĐ7mNó 9o@9opŕŔŠMóĐ7mNó`9oĐ7mNóůnĐ7mNó:o0:oĄpŕŔŠMóĐ7mNóP:oĐ7mNóůnĐ7mNó;o ;o1pŕŔŠMóĐ7mNó@;oĐ7mNóůnĐ7mNóđ;o<oÁpŕŔŠMóĐ7mNó0<oĐ7mNóůnĐ7mNóŕ<o=oQpŕŔŠMóĐ7mNó =oĐ7mNóůnĐ7mNóĐ=ođ=oápŕŔŠMóĐ7mNó>oĐ7mNóůnĐ7mNóŔ>oŕ>oqpŕŔŠMóĐ7mNó?oĐ7mNóůnĐ7mNó°?oĐ?opŕŔŠMóĐ7mNóđ?oĐ7mNóůnĐ7mNó @oŔ@opŕŔŠMóĐ7mNóŕ@oĐ7mNóůnĐ7mNóAo°Ao!pŕŔŠMóĐ7mNóĐAoĐ7mNóůnĐ7mNóBo BoąpŕŔŠMóĐ7mNóŔBoĐ7mNóůnĐ7mNópCoCoApŕŔŠMóĐ7mNó°CoĐ7mNóůnĐ7mNó`DoDoŃ
pŕŔŠMóĐ7mNó DoĐ7mNóůnĐ7mNóPEopEoa
pŕŔŠMóĐ7mNóEoĐ7mNóůnĐ7mNó@Fo`FońpŕŔŠMóĐ7mNóFoĐ7mNóůnĐ7mNó0GoPGopŕŔŠMóĐ7mNópGoĐ7mNóůnĐ7mNó Ho@HopŕŔŠMóĐ7mNó`HoĐ7mNóůnĐ7mNóIo0IoĄpŕŔŠMóĐ7mNó4oĐ7mNóůnĐ7mNóŕIožg1pŕŔŠMóĐ7mNó JoĐ7mNóůnĐ7mNóĐJođJoÁ
pŕŔŠMóĐ7mNóŔoĐ7mNóůnĐ7mNóŔKoŕKoQ
pŕŔŠMóĐ7mNóLoĐ7mNóůnĐ7mNó°LoĐLoá pŕŔŠMóĐ7mNóđLoĐ7mNóůnĐ7mNó MoŔMoq pŕŔŠMóĐ7mNópNoĐ7mNó@!oĐ7mNóŕMo pŕŔŠMóĐ7mNó@OoĐ7mNó@!oĐ7mNóOo OopŕŔŠMóĐ7mNóŔOoĐ7mNó@!oĐ7mNópPoPo!pŕŔŠMóĐ7mNó°PoĐ7mNó@!oĐ7mNó`QoQoąpŕŔŠMóĐ7mNó QoĐ7mNó@!oĐ7mNóPRopRoApŕŔŠMóĐ7mNóRoĐ7mNó@!oĐ7mNó@So`SoŃpŕŔŠMóĐ7mNóSoĐ7mNó@!oĐ7mNó0ToPToapŕŔŠMóĐ7mNópToĐ7mNó@!oĐ7mNó Uo@UońpŕŔŠMóĐ7mNó`UoĐ7mNó@!oĐ7mNóVo0VopŕŔŠMóĐ7mNóPVoĐ7mNó@!oĐ7mNóWo WopŕŔŠMóĐ7mNó@WoĐ7mNó@!oĐ7mNóđWoXoĄpŕŔŠMóĐ7mNó0XoĐ7mNó@!oĐ7mNóŕXoYo1pŕŔŠMóĐ7mNó YoĐ7mNó@!oĐ7mNóĐYođYoÁpŕŔŠMóĐ7mNó°NoĐ7mNó@!oĐ7mNó Zo[oQpŕŔŠMó`Đ7mNóŕZoĐ7mNó@!oĐ7mNóŔ[oŕ[oápŕŔŠMóĐ7mNó\oĐ7mNó@!oĐ7mNó°\oĐ\oqpŕŔŠMó Đ7mNóđ\oĐ7mNó@!oĐ7mNó ]oŔ]opŕŔŠMó@Đ7mNóŕ]oĐ7mNó@!oĐ7mNó^o°^opŕŔŠMó`Đ7mNóĐ^oĐ7mNó@!oĐ7mNó_očş{.nÇ+ˇŽ+%Ëlzwmébë§˛ćěr¸zX§ťŽwĽ{ayşĘÚë,j˘fŁ˘ˇhŕzšŽwĽ˘¸˘ˇŚj:+v¨wčjŘmś˙žŤęçzZ+ůÝ˘j"ú!śiOćŹzˇvŘ^śm§˙đĂnĆŕţY&

Next message: Rafael J. Wysocki: "Re: [PATCH 3/6] Container Freezer: Implement freezer cgroup subsystem"
Previous message: Alexey Dobriyan: "Re: [PATCH 2/2] cpuset: use seq_cpumask(), seq_nodemask()"
In reply to: Matt Helsley: "Re: [PATCH 2/6] Container Freezer: Make refrigerator alwaysavailable"
Next in thread: Matt Helsley: "Re: [PATCH 2/6] Container Freezer: Make refrigerator alwaysavailable"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]