Re: linux-next: Tree for July 30

From: Dmitry Torokhov
Date: Fri Aug 01 2008 - 15:24:36 EST


On Fri, Aug 01, 2008 at 12:12:19PM -0700, Linus Torvalds wrote:
>
> Ok, I apparently missed this whole subthread yesterday, only getting back
> to it when going over my old queues.
>
> On Thu, 31 Jul 2008, Dmitry Torokhov wrote:
> >
> > Input: paper over a bug in Synaptics X driver
>
> Yeah, it's not pretty, but how about moving that EV_KEY thing into the
> switch() statement?

I want to to be visually separated. It is not a hot path so extra
comparison won't hurt us.

> Also, the printk could certainly be a bit more useful.

I think I will follow Andrew's advice and point people to a page on
kernel.org (to be written).

> have that four-deep indentation by just splitting that horrible function
> up a bit.
>
> IOW, start off with a patch like the appended,

Makes sense. Signed-off-by please ;)

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/