[patch 2/2] [PATCH 2/2] x86: Fixed NULL function pointer dereference in AMD microcode patch loader.

From: Peter Oruba
Date: Fri Aug 01 2008 - 06:49:52 EST


Dereference took place in code part responsible for manual installation
of microcode patches through /dev/cpu/microcode.

Signed-off-by: Peter Oruba <peter.oruba@xxxxxxx>
---
arch/x86/kernel/microcode.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/microcode.c b/arch/x86/kernel/microcode.c
index 39961bb..ad136ad 100644
--- a/arch/x86/kernel/microcode.c
+++ b/arch/x86/kernel/microcode.c
@@ -127,7 +127,8 @@ static int do_microcode_update(void)
old = current->cpus_allowed;

while ((cursor = microcode_ops->get_next_ucode(&new_mc, cursor)) > 0) {
- error = microcode_ops->microcode_sanity_check(new_mc);
+ if (microcode_ops->microcode_sanity_check != NULL)
+ error = microcode_ops->microcode_sanity_check(new_mc);
if (error)
goto out;
/*
--
1.5.4.5




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/