Re: [PATCH] serial: change remove NR_IRQS in 8250.c

[Yinghai Lu]

On Thu, Jul 31, 2008 at 4:50 AM, Eric W. Biederman
<ebiederm@xxxxxxxxxxxx> wrote:
>> replace
>>       [PATCH] serial: change irq_lists to use dyn_array
>> use small array with index to handle irq locking for serial port
>> hope 32 slot is enough
>
> Could you size this array by NR_UARTS (our worst case usage)

how about crazy user set that too big?

> and place irq_no in struct irq_info?
should be ok
>
> Also you want to hold irq_info->lock when you set or clear irq_no.
> Just to be on the safe side.  I expect we can avoid clearing the irq_no
> in the irq_lists and prevent a few more races from being a possibility.

will try

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/