Re: [patch 0/4] x86: AMD microcode patch loading v2 fixes

From: Max Krasnyansky
Date: Thu Jul 31 2008 - 22:23:21 EST


Ingo Molnar wrote:
* Dmitry Adamushko <dmitry.adamushko@xxxxxxxxx> wrote:

I've even suggested to consider doing microcode update somewhere earlier in start_secondary() (say, right before cpu_idle()). So it'd be done as ealry as possible + we don't mess up with cpu-hotplug events.

i have no problems with that approach in principle. Microcode updates are special and black magic things anyway.


I still think we should just do the update via schedule_work_on() and be done with it. Maybe in theory it should be done as early as possible but in practice hotplug handler -> workqueue will be soon enough, I think.

Max
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/